Date: Sat, 18 Apr 2015 22:45:36 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau 
	<jeremie.galarneau@efficios.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        He Kuang <hekuang@huawei.com>, Ingo Molnar <mingo@kernel.org>,
        Jeremie Galarneau <jgalar@efficios.com>,
        Namhyung Kim <namhyung@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Tom Zanussi <tzanussi@gmail.com>, Wang Nan <wangnan0@huawei.com>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] perf data: Fix duplicate field names and avoid
 reserved keywords
Message-ID: <20150418204536.GB26943@krava.redhat.com>
References: <1429372220-6406-1-git-send-email-jolsa@kernel.org>
 <1429372220-6406-7-git-send-email-jolsa@kernel.org>
 <CA+jJMxvMwyV-KyRccLDsHvnBkm8F0-u=8+9BhC7o6ZSAcd8YGQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+jJMxvMwyV-KyRccLDsHvnBkm8F0-u=8+9BhC7o6ZSAcd8YGQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1133
Lines: 29

On Sat, Apr 18, 2015 at 02:56:00PM -0400, J?r?mie Galarneau wrote:
> On Sat, Apr 18, 2015 at 11:50 AM, Jiri Olsa <jolsa@kernel.org> wrote:
> > From: Wang Nan <wangnan0@huawei.com>
> >
> > Some parameters of syscall tracepoints named as 'nr', 'event', etc.
> > When dealing with them, perf convert to ctf meets some problem:
> >
> >  1. If a parameter with name 'nr', it will duplicate syscall's
> >     common field 'nr'. One such syscall is io_submit().
> >
> >  2. If a parameter with name 'event', it is denied to be inserted
> >     because 'event' is a babeltrace keywork. One such syscall is
> >     epoll_ctl.
> 
> Minor nitpick: "event" is a reserved keyword in the CTF specification
> [1], the rule is only enforced by Babeltrace. Also, keywork ->
> keyword.

thanks,

Arnaldo, any chance you could change it? (with ack from
He Kuang of course), or do you need a respin..

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/