Message-ID: <1429474813.2947.34.camel@perches.com>
Subject: Re: [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and
 eth_broadcast_addr()
From: Joe Perches <joe@perches.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: apw@canonical.com, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Sun, 19 Apr 2015 13:20:13 -0700
In-Reply-To: <1429470246-15988-3-git-send-email-mateusz.kulikowski@gmail.com>
References: <1429470246-15988-1-git-send-email-mateusz.kulikowski@gmail.com>
	 <1429470246-15988-3-git-send-email-mateusz.kulikowski@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1435
Lines: 46

On Sun, 2015-04-19 at 21:04 +0200, Mateusz Kulikowski wrote:
> Suggest using eth_zero_addr() or eth_broadcast_addr() if memset is used instead.

Hi Mateusz, this is OK but here are some notes:

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5042,6 +5042,22 @@ sub process {
[]
> +# check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr
> +# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
> +		if ($^V && $^V ge 5.10.0 &&
> +			$line =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) {

Please align the $line with the $^V above it.

> +
> +			my $ms_val = $7;
> +
> +			if ($ms_val =~ /^(0x|)0$/i) {

I've seen 0x00 many times so: /^(?:0x|)0+$/

> +				WARN("PREFER_ETH_ZERO_ADDR",
> +					  "Prefer eth_zero_addr over memset()\n" . $herecurr);

Please align to the initial open quote here:

				WARN("PREFER_ETH_ZERO_ADDR",
				     "Prefer eth_zero_addr over memset()\n" . $herecurr);

> +			} elsif ($ms_val =~ /^0xff$/i) {

255 here too so: /^(?:0xff|255)$/

> +				WARN("PREFER_ETH_BROADCAST_ADDR",
> +					  "Prefer eth_broadcast_addr() over memset()\n" . $herecurr);

Please align to open quote


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/