Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753283AbbDSUXI (ORCPT ); Sun, 19 Apr 2015 16:23:08 -0400 Received: from smtprelay0225.hostedemail.com ([216.40.44.225]:41440 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752013AbbDSUXF (ORCPT ); Sun, 19 Apr 2015 16:23:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1561:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3622:3865:3867:3868:3871:3873:3874:4250:4321:5007:6261:10004:10400:10848:11026:11232:11658:11914:12438:12517:12519:12740:13069:13071:13311:13357:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: art92_8f20112dc7b32 X-Filterd-Recvd-Size: 1319 Message-ID: <1429474981.2947.36.camel@perches.com> Subject: Re: [PATCH 1/2] checkpatch: suggest using ether_addr_equal*() From: Joe Perches To: Mateusz Kulikowski Cc: apw@canonical.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 19 Apr 2015 13:23:01 -0700 In-Reply-To: <1429470246-15988-2-git-send-email-mateusz.kulikowski@gmail.com> References: <1429470246-15988-1-git-send-email-mateusz.kulikowski@gmail.com> <1429470246-15988-2-git-send-email-mateusz.kulikowski@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 18 On Sun, 2015-04-19 at 21:04 +0200, Mateusz Kulikowski wrote: > Check if memcmp() is used to compare ethernet addresses and suggest using > ether_addr_equal() or ether_addr_equal_unaligned() Hi again Mateusz. This is OK with me. If you ever submit that ether_addr_copy_unaligned patch, please update the checkpatch test for ether_addr_copy too. Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/