Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752501AbbDTCLM (ORCPT <rfc822;w@1wt.eu>);
	Sun, 19 Apr 2015 22:11:12 -0400
Received: from mail-qg0-f45.google.com ([209.85.192.45]:33349 "EHLO
	mail-qg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751429AbbDTCLH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 19 Apr 2015 22:11:07 -0400
Message-ID: <5534603a.36208c0a.4784.6286@mx.google.com>
Date: Sun, 19 Apr 2015 19:11:06 -0700 (PDT)
From: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
To: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>, Andrew Morton <akpm@linux-foundation.org>,
        Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
        Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        <izumi.taku@jp.fujitsu.com>, Tang Chen <tangchen@cn.fujitsu.com>,
        Gu Zheng <guz.fnst@cn.fujitsu.com>, Xiexiuqi <xiexiuqi@huawei.com>,
        Mel Gorman <mgorman@suse.de>, David Rientjes <rientjes@google.com>,
        Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()
References: <5530E578.9070505@huawei.com>
	<5531679d.4642ec0a.1beb.3569@mx.google.com>
	<55345756.40902@huawei.com>
X-Mailer: Sylpheed 3.4.2 (GTK+ 2.10.14; i686-pc-mingw32)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1768
Lines: 66


> When hot adding memory and creating new node, the node is offline.
> And after calling node_set_online(), the node becomes online.
> 
> Oh, sorry. I misread your ptaches.
> 

Please ignore it...

Thanks,
Yasuaki Ishimatsu

On 
Yasuaki Ishimatsu <yasu.isimatu@gmail.com> wrote:

> 
> When hot adding memory and creating new node, the node is offline.
> And after calling node_set_online(), the node becomes online.
> 
> Oh, sorry. I misread your ptaches.
> 
> Thanks,
> Yasuaki Ishimatsu
> 
> On Mon, 20 Apr 2015 09:33:10 +0800
> Xishi Qiu <qiuxishi@huawei.com> wrote:
> 
> > On 2015/4/18 4:05, Yasuaki Ishimatsu wrote:
> > 
> > > 
> > > Your patches will fix your issue.
> > > But, if BIOS reports memory first at node hot add, pgdat can
> > > not be initialized.
> > > 
> > > Memory hot add flows are as follows:
> > > 
> > > add_memory
> > >   ...
> > >   -> hotadd_new_pgdat()
> > >   ...
> > >   -> node_set_online(nid)
> > > 
> > > When calling hotadd_new_pgdat() for a hot added node, the node is
> > > offline because node_set_online() is not called yet. So if applying
> > > your patches, the pgdat is not initialized in this case.
> > > 
> > > Thanks,
> > > Yasuaki Ishimatsu
> > > 
> > 
> > Hi Yasuaki,
> > 
> > I'm not quite understand, when BIOS reports memory first, why pgdat
> > can not be initialized?
> > When hotadd a new node, hotadd_new_pgdat() will be called too, and
> > when hotadd memory to a existent node, it's no need to call hotadd_new_pgdat(),
> > right?
> > 
> > Thanks,
> > Xishi Qiu
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/