Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753268AbbDTDIV (ORCPT ); Sun, 19 Apr 2015 23:08:21 -0400 Received: from exprod5og113.obsmtp.com ([64.18.0.26]:54706 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752782AbbDTDIT (ORCPT ); Sun, 19 Apr 2015 23:08:19 -0400 MIME-Version: 1.0 In-Reply-To: <20150417182937.GN30624@intel.com> References: <1429212673-22254-1-git-send-email-rsahu@apm.com> <20150417182937.GN30624@intel.com> Date: Mon, 20 Apr 2015 08:38:18 +0530 Message-ID: Subject: Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings From: Rameshwar Sahu To: Vinod Koul Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 50 Hi Vinod, On Fri, Apr 17, 2015 at 11:59 PM, Vinod Koul wrote: > >> /* Get DMA error interrupt */ >> @@ -2076,7 +2035,6 @@ static struct platform_driver xgene_dma_driver = { >> .remove = xgene_dma_remove, >> .driver = { >> .name = "X-Gene-DMA", >> - .owner = THIS_MODULE, > I have already applied a patch for this Okay, I didn't pull latest git > >> .of_match_table = xgene_dma_of_match_ptr, >> }, >> }; >> @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver); >> >> MODULE_DESCRIPTION("APM X-Gene SoC DMA driver"); >> MODULE_AUTHOR("Rameshwar Prasad Sahu "); >> -MODULE_AUTHOR("Loc Ho "); > And why this? I saw below warning reported by the kbuild robot test drivers/dma/xgene-dma.c:2088:1: sparse: symbol '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally initialized at drivers/dma/xgene-dma.c:2087) So, I kept only one author here. > > Fixes looks good though > > -- > ~Vinod >> MODULE_LICENSE("GPL"); >> MODULE_VERSION("1.0"); >> -- >> 1.8.2.1 >> > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/