Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbbDTEOJ (ORCPT ); Mon, 20 Apr 2015 00:14:09 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:33147 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbbDTEOF convert rfc822-to-8bit (ORCPT ); Mon, 20 Apr 2015 00:14:05 -0400 MIME-Version: 1.0 In-Reply-To: <1429195312-25898-1-git-send-email-orjan.eide@arm.com> References: <1429195312-25898-1-git-send-email-orjan.eide@arm.com> From: Daniel Kurtz Date: Mon, 20 Apr 2015 12:13:43 +0800 X-Google-Sender-Auth: Zb8RhCaeFMs00m1D_rvzMs_-Jic Message-ID: Subject: Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api To: =?UTF-8?Q?=C3=98rjan_Eide?= Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dri-devel , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1789 Lines: 54 Hi Ørjan, On Thu, Apr 16, 2015 at 10:41 PM, Ørjan Eide wrote: > > Set vm_pgoff to 0 after using it to look up the GEM node, before passing > it on rockchip_gem_mmap_buf() where the offset must be from the start of > the buffer. > > Passing in the fake offset currently works because the > dma_mmap_attrs implementation that is used for this device, > arm_iommu_mmap_attrs, ignores the offset completely. > > Signed-off-by: Ørjan Eide > > --- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > index 7ca8799e..69f01c3 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct vm_area_struct *vma) > return -EACCES; > } > > + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the > + * whole buffer from the start. > + */ One very tiny nit. According to [0], multi-line comments start are supposed to start with a single "/*" [0] https://www.kernel.org/doc/Documentation/CodingStyle Other than that, this patch is Reviewed-by: Daniel Kurtz Thanks for sending this up! > > + vma->vm_pgoff = 0; > + > obj = container_of(node, struct drm_gem_object, vma_node); > ret = rockchip_gem_mmap_buf(obj, vma); > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/