Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754544AbbDTHL7 (ORCPT ); Mon, 20 Apr 2015 03:11:59 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:33569 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbbDTHL5 (ORCPT ); Mon, 20 Apr 2015 03:11:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <1429284290-25153-3-git-send-email-tomeu.vizoso@collabora.com> From: Tomeu Vizoso Date: Mon, 20 Apr 2015 09:11:36 +0200 X-Google-Sender-Auth: hYNM1mqOaCHcFGMvHoowepXWduE Message-ID: Subject: Re: [PATCH v3 2/2] [media] uvcvideo: Remain runtime-suspended at sleeps To: Alan Stern Cc: "linux-pm@vger.kernel.org" , Laurent Pinchart , Dmitry Torokhov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1790 Lines: 49 On 17 April 2015 at 19:32, Alan Stern wrote: > On Fri, 17 Apr 2015, Tomeu Vizoso wrote: > >> When the system goes to sleep and afterwards resumes, a significant >> amount of time is spent suspending and resuming devices that were >> already runtime-suspended. >> >> By setting the power.force_direct_complete flag, the PM core will ignore >> the state of descendant devices and the device will be let in >> runtime-suspend. >> >> Signed-off-by: Tomeu Vizoso >> --- >> drivers/media/usb/uvc/uvc_driver.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c >> index 5970dd6..ae75a70 100644 >> --- a/drivers/media/usb/uvc/uvc_driver.c >> +++ b/drivers/media/usb/uvc/uvc_driver.c >> @@ -1945,6 +1945,8 @@ static int uvc_probe(struct usb_interface *intf, >> "supported.\n", ret); >> } >> >> + intf->dev.parent->power.force_direct_complete = true; > > This seems wrong. The uvc driver is bound to intf, not to intf's > parent. So it would be okay for the driver to set > intf->dev.power.force_direct_complete, but it's wrong to set > intf->dev.parent->power.force_direct_complete. Agreed. Thanks, Tomeu > Alan Stern > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/