Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719AbbDTHsz (ORCPT ); Mon, 20 Apr 2015 03:48:55 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:38362 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981AbbDTHsw (ORCPT ); Mon, 20 Apr 2015 03:48:52 -0400 From: Eli Cohen X-Google-Original-From: Eli Cohen Date: Mon, 20 Apr 2015 10:48:48 +0300 To: Honggang Li Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH linux-next v5] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures Message-ID: <20150420074848.GA17506@mtldesk30> References: <1429086975-15506-1-git-send-email-honli@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429086975-15506-1-git-send-email-honli@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 39 On Wed, Apr 15, 2015 at 04:36:15PM +0800, Honggang Li wrote: > If CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for x86 systems and physical > memory is more than 4GB, dma_map_page may return a valid memory > address which greater than 0xffffffff. As a result, the mlx5 device page > allocator RB tree will be initialized with valid addresses greater than > 0xfffffff. > > However, (addr & PAGE_MASK) set the high four bytes to zeros. So, it's > impossible for the function, free_4k, to release the pages whose > addresses greater than 4GB. Memory leaks. And mlx5_ib module can't > release the pages when user try to remove the module, as a result, > system hang. > > [root@rdma05 root]# dmesg | grep addr | head > addr = 3fe384000 > addr & PAGE_MASK = fe384000 > [root@rdma05 root]# rmmod mlx5_ib <---- hang on > > ---------------------- cosnole log ----------------- > mlx5_ib 0000:04:00.0: irq 138 for MSI/MSI-X > alloc irq_desc for 139 on node -1 > alloc kstat_irqs on node -1 > mlx5_ib 0000:04:00.0: irq 139 for MSI/MSI-X > 0000:04:00.0:free_4k:221:(pid 1519): page not found > 0000:04:00.0:free_4k:221:(pid 1519): page not found > 0000:04:00.0:free_4k:221:(pid 1519): page not found > 0000:04:00.0:free_4k:221:(pid 1519): page not found > ---------------------- cosnole log ----------------- > > Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size to firmware') > Signed-off-by: Honggang Li > --- Acked-by: Eli Cohen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/