Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753956AbbDTICX (ORCPT ); Mon, 20 Apr 2015 04:02:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30041 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbbDTICV (ORCPT ); Mon, 20 Apr 2015 04:02:21 -0400 Date: Mon, 20 Apr 2015 11:02:09 +0300 From: Dan Carpenter To: Yorick Rommers Cc: gregkh@linuxfoundation.org, alan@linux.intel.com, helen.fornazier@gmail.com, iskaranth@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c Message-ID: <20150420080209.GR10964@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 27 On Sat, Apr 18, 2015 at 10:12:14PM +0200, Yorick Rommers wrote: > From: Yorick Don't include a From: unless you are sending a patch someone else wrote. Otherwise we prefer to get it from your email From. Also you forgot your last name. > @@ -488,8 +488,8 @@ static int i2o_block_reply(struct i2o_controller *c, u32 m, > * Don't stick a supertrak100 into cache aggressive modes > */ > > - osm_err("TID %03x error status: 0x%02x, detailed status: " > - "0x%04x\n", (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff), > + osm_err("TID %03x error status: 0x%02x, detailed status: 0x%04x\n", > + (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff), > status >> 24, status & 0xffff); The new indenting is wrong. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/