Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754314AbbDTIJA (ORCPT ); Mon, 20 Apr 2015 04:09:00 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33894 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641AbbDTII5 (ORCPT ); Mon, 20 Apr 2015 04:08:57 -0400 Date: Mon, 20 Apr 2015 11:08:40 +0300 From: Dan Carpenter To: Yorick Rommers Cc: gregkh@linuxfoundation.org, markh@compro.net, lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Staging: dgnc: fixed code style issues, mainly line width issues. Message-ID: <20150420080840.GS10964@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2455 Lines: 64 On Sun, Apr 19, 2015 at 02:04:39AM +0200, Yorick Rommers wrote: > A patch for dgnc_mgmt.c and dgnc_neo.c to fix some code style issues. > > Signed-off-by: Yorick Rommers > --- > drivers/staging/dgnc/dgnc_mgmt.c | 4 +- > drivers/staging/dgnc/dgnc_neo.c | 210 +++++++++++++++++++++++++++------------ > 2 files changed, 151 insertions(+), 63 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c > index b13318a..2385da8 100644 > --- a/drivers/staging/dgnc/dgnc_mgmt.c > +++ b/drivers/staging/dgnc/dgnc_mgmt.c > @@ -148,7 +148,9 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > di.info_bdstate = dgnc_Board[brd]->dpastatus; > di.info_ioport = 0; > di.info_physaddr = (ulong) dgnc_Board[brd]->membase; > - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; > + di.info_physsize = > + (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; New indenting is bad. > + > if (dgnc_Board[brd]->state != BOARD_FAILED) > di.info_nports = dgnc_Board[brd]->nasync; > else > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c > index f5a4d36..23afd78 100644 > --- a/drivers/staging/dgnc/dgnc_neo.c > +++ b/drivers/staging/dgnc/dgnc_neo.c > @@ -79,7 +79,8 @@ struct board_ops dgnc_neo_ops = { > .send_immediate_char = neo_send_immediate_char > }; > > -static uint dgnc_offset_table[8] = { 0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80 }; > +static uint dgnc_offset_table[8] = { 0x01, 0x02, 0x04, 0x08, > +0x10, 0x20, 0x40, 0x80 }; New indenting is bad. > @@ -333,7 +358,8 @@ static inline void neo_set_new_start_stop_chars(struct channel_t *ch) > { > > /* if hardware flow control is set, then skip this whole thing */ > - if (ch->ch_digi.digi_flags & (CTSPACE | RTSPACE) || ch->ch_c_cflag & CRTSCTS) > + if (ch->ch_digi.digi_flags & > + (CTSPACE | RTSPACE) || ch->ch_c_cflag & CRTSCTS) New indenting is bad. It should be: if (ch->ch_digi.digi_flags & (CTSPACE | RTSPACE) || ch->ch_c_cflag & CRTSCTS) There are several more mistakes with the patch but you get the idea. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/