Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754511AbbDTI2G (ORCPT ); Mon, 20 Apr 2015 04:28:06 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:16632 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753854AbbDTI2D (ORCPT ); Mon, 20 Apr 2015 04:28:03 -0400 Date: Mon, 20 Apr 2015 11:27:46 +0300 From: Dan Carpenter To: Yorick Rommers Cc: joe@perches.com, devel@driverdev.osuosl.org, lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences. Message-ID: <20150420082745.GV10964@mwanda> References: <1429475676.2947.43.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 35 On Sun, Apr 19, 2015 at 11:58:53PM +0200, Yorick Rommers wrote: > Hello Joe, > > Thank you once again for the feedback. > I've changed my patch accordingly, see below. > > -------------------------------------- The patch is nice except for this chunk. And also you should be putting version numbers in the patch description: [PATCH v4] Staging: dgnc: Using temporary variable to save space > > A patch for a line being too long (>80) in dgnc_mgmt.c, > fixed by making a temporary value for dgnc_Board[brd], > replacing all instanced of dgnc_Board[brd] with temporary value, > and removing unnecessary typecasts. > > Signed-off-by: Yorick Rommers > --- And put a note under the cut off here. --- v4: Removed email to Joe Perches from the patch description regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/