Message-ID: <5534D48A.20304@arm.com>
Date: Mon, 20 Apr 2015 11:27:22 +0100
From: Juri Lelli <juri.lelli@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Wanpeng Li <wanpeng.li@linux.intel.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/7] sched/deadline: reschedule if stop task slip in after
 pull operations
References: <1428310399-13489-1-git-send-email-wanpeng.li@linux.intel.com> <1428310399-13489-4-git-send-email-wanpeng.li@linux.intel.com>
In-Reply-To: <1428310399-13489-4-git-send-email-wanpeng.li@linux.intel.com>
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1911
Lines: 61

Hi,

On 06/04/2015 09:53, Wanpeng Li wrote:
> pull_dl_task can drop (and re-acquire) rq->lock, this means a stop task 
> can slip in, in which case we need to reschedule. This patch add the 
> reschedule when the scenario occurs.
> 

Ok, I guess it can happen. Doesn't RT have the same problem? It seems that
it also has to deal with DL tasks slipping in, right?

Thanks,

- Juri

> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
> ---
>  kernel/sched/deadline.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index b8b9355..844da0f 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1739,7 +1739,13 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p)
>  	if (!task_on_rq_queued(p) || rq->dl.dl_nr_running)
>  		return;
>  
> -	if (pull_dl_task(rq))
> +	/*
> +	 * pull_dl_task() can drop (and re-acquire) rq->lock; this
> +	 * means a stop task can slip in, in which case we need to
> +	 * reschedule.
> +	 */
> +	if (pull_dl_task(rq) ||
> +		(rq->stop && task_on_rq_queued(rq->stop)))
>  		resched_curr(rq);
>  }
>  
> @@ -1786,6 +1792,14 @@ static void prio_changed_dl(struct rq *rq, struct task_struct *p,
>  			pull_dl_task(rq);
>  
>  		/*
> +		 * pull_dl_task() can drop (and re-acquire) rq->lock; this
> +		 * means a stop task can slip in, in which case we need to
> +		 * reschedule.
> +		 */
> +		if (rq->stop && task_on_rq_queued(rq->stop))
> +			resched_curr(rq);
> +
> +		/*
>  		 * If we now have a earlier deadline task than p,
>  		 * then reschedule, provided p is still on this
>  		 * runqueue.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/