Message-ID: <5534D721.1060206@radekdostal.com>
Date: Mon, 20 Apr 2015 12:38:25 +0200
From: =?windows-1252?Q?Radek_Dost=E1l?= <rd@radekdostal.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Chris Wilson <chris@chris-wilson.co.uk>, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] drm: fb_helper: prefer to use mode, which is not DRM_MODE_TYPE_USERDEF
References: <1429477553-10294-1-git-send-email-rd@radekdostal.com> <1429507593-21172-1-git-send-email-rd@radekdostal.com> <20150420090929.GC25451@nuc-i3427.alporthouse.com> <5534C884.8080101@radekdostal.com> <20150420094608.GD25451@nuc-i3427.alporthouse.com> <20150420095818.GE25451@nuc-i3427.alporthouse.com>
In-Reply-To: <20150420095818.GE25451@nuc-i3427.alporthouse.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 900
Lines: 26

Hi Chris,

On 04/20/2015 11:58 AM, Chris Wilson wrote:
> Hmm, so that should be before the clock comparison as well to fix your
> example. Not as neat.

indeed that is required.

> The other idea I was considering was not adding the GTF cmdline mode if
> the probed modes already contain one of a matching resolution. The goal
> here is to also not present a mode to userspace that is invalid.

Unfortunately you can not do that. I already tried. At the time when
drm_helper_probe_add_cmdline_mode is called EDID informations are not
yet available.

Only option would be to remove the GTF cmdline mode, when matching mode
is found in EDID.

Thanks,
Radek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/