Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754894AbbDTMA4 (ORCPT ); Mon, 20 Apr 2015 08:00:56 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:35706 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754548AbbDTMAx (ORCPT ); Mon, 20 Apr 2015 08:00:53 -0400 Message-ID: <5534EA72.5030607@radekdostal.com> Date: Mon, 20 Apr 2015 14:00:50 +0200 From: =?windows-1252?Q?Radek_Dost=E1l?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Chris Wilson , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] drm: fb_helper: prefer to use mode, which is not DRM_MODE_TYPE_USERDEF References: <1429507593-21172-1-git-send-email-rd@radekdostal.com> <20150420090929.GC25451@nuc-i3427.alporthouse.com> <5534C884.8080101@radekdostal.com> <20150420094608.GD25451@nuc-i3427.alporthouse.com> <20150420095818.GE25451@nuc-i3427.alporthouse.com> <5534D721.1060206@radekdostal.com> <20150420104852.GF25451@nuc-i3427.alporthouse.com> <5534DB9D.6040109@radekdostal.com> <20150420110049.GG25451@nuc-i3427.alporthouse.com> <5534E0E5.6020101@radekdostal.com> <20150420114450.GH25451@nuc-i3427.alporthouse.com> In-Reply-To: <20150420114450.GH25451@nuc-i3427.alporthouse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1626 Lines: 37 Hi Chris, On 04/20/2015 01:44 PM, Chris Wilson wrote: > Ah, maybe this on top of the previous try: > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index 88f5a74..5d22ca0 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -87,7 +87,7 @@ static int drm_helper_probe_add_cmdline_mode(struct drm_connector *connector) > return 0; > > /* Only add a GTF mode if we find no matching probed modes */ > - list_for_each_entry(mode, &connector->modes, head) { > + list_for_each_entry(mode, &connector->probed_modes, head) { > if (mode->hdisplay != cmdline_mode->xres || > mode->vdisplay != cmdline_mode->yres) > continue; > @@ -211,7 +211,8 @@ static int drm_helper_probe_single_connector_modes_merge_bits(struct drm_connect > mode_flags |= DRM_MODE_FLAG_3D_MASK; > > list_for_each_entry(mode, &connector->modes, head) { > - mode->status = drm_mode_validate_basic(mode); > + if (mode->status == MODE_OK) > + mode->status = drm_mode_validate_basic(mode); > > if (mode->status == MODE_OK) > mode->status = drm_mode_validate_size(mode, maxX, maxY perfect - this seems to work :) Radek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/