Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755485AbbDTNEd (ORCPT ); Mon, 20 Apr 2015 09:04:33 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:33526 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbbDTNEb (ORCPT ); Mon, 20 Apr 2015 09:04:31 -0400 Date: Mon, 20 Apr 2015 14:04:26 +0100 From: Peter Griffin To: Tejun Heo Cc: Maxime Coquelin , Brian Norris , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, kernel@stlinux.com, Srinivas Kandagatla , Patrice Chotard Subject: Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors Message-ID: <20150420130426.GA906@griffinp-ThinkPad-X1-Carbon-2nd> References: <1428519599-31885-1-git-send-email-computersforpeace@gmail.com> <552627BD.9060109@st.com> <20150409094310.GA29026@griffinp-ThinkPad-X1-Carbon-2nd> <20150417145558.GD1954@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150417145558.GD1954@htj.duckdns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 30 Hi Tejun, On Fri, 17 Apr 2015, Tejun Heo wrote: > On Thu, Apr 09, 2015 at 10:43:10AM +0100, Peter Griffin wrote: > > Yes I can test, although not until Saturday as I only have remote > > access to the board today & tomorrow and the hard drive isn't > > plugged in. > > What's the status on this patch? Should I push it through > for-4.1-fixes? The layering violation which Brian identified does need fixing. However please don't take this patch as it currently is, as it causes a NULL ptr dereference. I can send an updated version in a moment which: - 1) Fixes the conflict you will get when applying it for v4.1 (due to my "st_configure_oob must be called after IP is clocked" patch). 2) Fixes the crash which this patch introduces. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/