Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755579AbbDTOCs (ORCPT ); Mon, 20 Apr 2015 10:02:48 -0400 Received: from mail.kernel.org ([198.145.29.136]:46378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753244AbbDTOCn (ORCPT ); Mon, 20 Apr 2015 10:02:43 -0400 Date: Mon, 20 Apr 2015 11:02:38 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau , Jiri Olsa , David Ahern , Frederic Weisbecker , He Kuang , Ingo Molnar , Jeremie Galarneau , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Sebastian Andrzej Siewior , Tom Zanussi , Wang Nan , lkml Subject: Re: [PATCH 6/7] perf data: Fix duplicate field names and avoid reserved keywords Message-ID: <20150420140238.GG11111@kernel.org> References: <1429372220-6406-1-git-send-email-jolsa@kernel.org> <1429372220-6406-7-git-send-email-jolsa@kernel.org> <20150418204536.GB26943@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150418204536.GB26943@krava.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 33 Em Sat, Apr 18, 2015 at 10:45:36PM +0200, Jiri Olsa escreveu: > On Sat, Apr 18, 2015 at 02:56:00PM -0400, J?r?mie Galarneau wrote: > > On Sat, Apr 18, 2015 at 11:50 AM, Jiri Olsa wrote: > > > From: Wang Nan > > > > > > Some parameters of syscall tracepoints named as 'nr', 'event', etc. > > > When dealing with them, perf convert to ctf meets some problem: > > > > > > 1. If a parameter with name 'nr', it will duplicate syscall's > > > common field 'nr'. One such syscall is io_submit(). > > > > > > 2. If a parameter with name 'event', it is denied to be inserted > > > because 'event' is a babeltrace keywork. One such syscall is > > > epoll_ctl. > > > > Minor nitpick: "event" is a reserved keyword in the CTF specification > > [1], the rule is only enforced by Babeltrace. Also, keywork -> > > keyword. > > thanks, > > Arnaldo, any chance you could change it? (with ack from I'll do it > He Kuang of course), or do you need a respin.. > > jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/