Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754789AbbDTPkm (ORCPT ); Mon, 20 Apr 2015 11:40:42 -0400 Received: from resqmta-po-12v.sys.comcast.net ([96.114.154.171]:58790 "EHLO resqmta-po-12v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbbDTPkj (ORCPT ); Mon, 20 Apr 2015 11:40:39 -0400 Date: Mon, 20 Apr 2015 10:40:36 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Gavin Guo cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slab_common: Support the slub_debug boot option on specific object size In-Reply-To: <1429349091-11785-1-git-send-email-gavin.guo@canonical.com> Message-ID: References: <1429349091-11785-1-git-send-email-gavin.guo@canonical.com> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 18 On Sat, 18 Apr 2015, Gavin Guo wrote: > The slub_debug=PU,kmalloc-xx cannot work because in the > create_kmalloc_caches() the s->name is created after the > create_kmalloc_cache() is called. The name is NULL in the > create_kmalloc_cache() so the kmem_cache_flags() would not set the > slub_debug flags to the s->flags. The fix here set up a temporary > kmalloc_names string array for the initialization purpose. After the > kmalloc_caches are already it can be used to create s->name in the > kasprintf. Ok if you do that then the dynamic creation of the kmalloc hostname can also be removed. This patch should do that as well. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/