Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755280AbbDTQLo (ORCPT ); Mon, 20 Apr 2015 12:11:44 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34318 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754404AbbDTQLl convert rfc822-to-8bit (ORCPT ); Mon, 20 Apr 2015 12:11:41 -0400 Message-ID: <55352535.3030505@free-electrons.com> Date: Mon, 20 Apr 2015 18:11:33 +0200 From: Michael Opdenacker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Valdez, Jonathan" CC: dmitry.torokhov@gmail.com, kyle.manna@fuel7.com, hns@goldelico.com, linux-input@vger.kernel.org, Linux Kernel Mailing List Subject: Re: Input: tca8418-keypad: Incorrect values in a driver References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 57 Hi Jonathan, Thank you for reporting this issue! On 03/30/2015 06:41 PM, Valdez, Jonathan wrote: > > Hello, > > > > I?ve been supporting the TCA8418 and have been pointed to your > document by a few customers > (http://lxr.free-electrons.com/source/drivers/input/keyboard/tca8418_keypad.c) > > > > > > The problem I am seeing is that you are writing a 1 to > REG_DEBOUNCE_DIS1/2/3, which actually disables column debouncing. A 0 > enables it. This is easily fixed, but I wanted to bring this to your > attention. > > > > Please see page 19 of the TCA8418 datasheet, where the registers are > debounce_DIS(able) registers. A 0 keeps debouncing enabled. By default > debounce is enabled. > > > > Best regards, > > Jonathan Valdez > > System Connectivity Applications > I'm not the maintainer of this code though, just showing the source code on our LXR webste. I'm CCing the guys in charge. Cheers, Michael. -- Michael Opdenacker, CEO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com +33 484 258 098 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/