Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbbDTRC4 (ORCPT ); Mon, 20 Apr 2015 13:02:56 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:35792 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbbDTRCx (ORCPT ); Mon, 20 Apr 2015 13:02:53 -0400 MIME-Version: 1.0 Reply-To: charliemooney@chromium.org In-Reply-To: <20150418034336.GA31454@dtor-ws> References: <20150418034336.GA31454@dtor-ws> From: Charles Mooney Date: Mon, 20 Apr 2015 10:02:12 -0700 X-Google-Sender-Auth: UUz1nsUK8QuuqzFQ1fbIY8Wmfs4 Message-ID: Subject: Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Scott Liu , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 39 On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov wrote: > Let's zero-extend hardware id number when forming firmware file name, > to avoid kernel requesting firmware like "elants_i2c_ 0.bin", which > is quite unexpected. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/elants_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c > index 43b3c9c..0efd766 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts) > char *fw_name; > int error; > > - fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%4x.bin", ts->hw_version); > + fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%04x.bin", ts->hw_version); > if (!fw_name) > return -ENOMEM; > > -- > 2.2.0.rc0.207.ga3a616c > > > -- > Dmitry Looks good to me. Acked-by: Charlie Mooney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/