Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754084AbbDTRjA (ORCPT ); Mon, 20 Apr 2015 13:39:00 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:50647 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751791AbbDTRi7 (ORCPT ); Mon, 20 Apr 2015 13:38:59 -0400 Date: Mon, 20 Apr 2015 13:38:58 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ramneek Mehresh cc: "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "balbi@ti.com" , "gregkh@linuxfoundation.org" Subject: RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 26 On Mon, 20 Apr 2015, Ramneek Mehresh wrote: > > > This is the wrong way to connect platform-private data with the > > > ehci_hcd structure. The right way is to use an ehci_driver_overrides > > > structure, like in ehci-omap.c and quite a few other EHCI platform drivers. > > > > > > Hi Alan, I checked again...we are not connecting ehci_hcd structure here with > platform-private data. We are just having a wrapper on it to have some additional > Information that can be used for ehci fsl driver. This additional information is > private to ehci fsl driver, and is mainly used for otg driver functionality and to > save/restore fsl regsiters during deep-sleep It doesn't matter -- private data is private data, whether it is platform-private or driver-private. Either way, you can't wrap ehci-hcd in anything. The private data has to added to the end, the way ehci-omap.c does it. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/