Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755681AbbDTSTf (ORCPT ); Mon, 20 Apr 2015 14:19:35 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46073 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753128AbbDTSTR (ORCPT ); Mon, 20 Apr 2015 14:19:17 -0400 Date: Mon, 20 Apr 2015 14:19:14 -0400 (EDT) Message-Id: <20150420.141914.1605864056122893264.davem@davemloft.net> To: mateusz.kulikowski@gmail.com Cc: joe@perches.com, dan.carpenter@oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] etherdevice: Add ether_addr_copy_unaligned From: David Miller In-Reply-To: <1429479577-3977-1-git-send-email-mateusz.kulikowski@gmail.com> References: <1429479577-3977-1-git-send-email-mateusz.kulikowski@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Apr 2015 11:19:16 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 18 From: Mateusz Kulikowski Date: Sun, 19 Apr 2015 23:39:37 +0200 > Some drivers require copying unaligned ethernet addresses. > Using memcpy() causes checkpatch warnings and may cause > regressions (someone will "fix" alignment of packed structure) > > Signed-off-by: Mateusz Kulikowski I'd rather see something like this submitted in a patch series alongside some actual uses. So I'm tossing this for now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/