Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbbDTT7S (ORCPT ); Mon, 20 Apr 2015 15:59:18 -0400 Received: from www.linutronix.de ([62.245.132.108]:55544 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbbDTT7N (ORCPT ); Mon, 20 Apr 2015 15:59:13 -0400 Date: Mon, 20 Apr 2015 21:59:01 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: arnd@arndb.de, john.stultz@linaro.org, heenasirwani@gmail.com, pang.xunlei@linaro.org, peterz@infradead.org, rafael.j.wysocki@intel.com, gregkh@linuxfoundation.org, richardcochran@gmail.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, rth@twiddle.net, riel@redhat.com, cl@linux.com, tj@kernel.org, fweisbec@gmail.com, ahh@google.com, pjt@google.com, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit In-Reply-To: Message-ID: References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> <1429509459-17068-2-git-send-email-baolin.wang@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 41 On Mon, 20 Apr 2015, Thomas Gleixner wrote: > On Mon, 20 Apr 2015, Baolin Wang wrote: > > This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec, > > and also introduces the conversion methods: itimerspec64_to_itimerspec() and > > itimerspec_to_itimerspec64(), that makes itimerspec to ready for 2038 year. > > > > Signed-off-by: Baolin Wang > > --- > > include/linux/time64.h | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/include/linux/time64.h b/include/linux/time64.h > > index a383147..3647bdd 100644 > > --- a/include/linux/time64.h > > +++ b/include/linux/time64.h > > @@ -18,6 +18,11 @@ struct timespec64 { > > }; > > #endif > > > > +struct itimerspec64 { > > + struct timespec64 it_interval; /* timer period */ > > + struct timespec64 it_value; /* timer expiration */ > > +}; Aside of the macro mess. This really wants to be conditional on 64/32 but in the same way as we have the different implementations for timespec64. Your patch enforces a useless conversion from and to itimerspec64 even on 64 bit because the compiler cannot map the types. Sigh. timespec64 is a proper guidance here. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/