Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbbDTUR3 (ORCPT ); Mon, 20 Apr 2015 16:17:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42230 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbbDTUR0 (ORCPT ); Mon, 20 Apr 2015 16:17:26 -0400 Date: Mon, 20 Apr 2015 13:17:25 -0700 From: Andrew Morton To: Chris Metcalf Cc: Rasmus Villemoes , Tejun Heo , "Peter Zijlstra (Intel)" , Sudeep Holla , "Michal Nazarewicz" , , Subject: Re: [PATCH] __bitmap_parselist: fix bug in empty string handling Message-Id: <20150420131725.3491233d901f1231af8fbc5d@linux-foundation.org> In-Reply-To: <1429293604-5210-1-git-send-email-cmetcalf@ezchip.com> References: <1429293604-5210-1-git-send-email-cmetcalf@ezchip.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 21 On Fri, 17 Apr 2015 14:00:04 -0400 Chris Metcalf wrote: > bitmap_parselist("", &mask, nmaskbits) will erroneously set bit > zero in the mask. The same bug is visible in cpumask_parselist() > since it is layered on top of the bitmask code, e.g. if you boot with > "isolcpus=", you will actually end up with cpu zero isolated. > > The bug was introduced in commit 4b060420a596 ("bitmap, irq: add > smp_affinity_list interface to /proc/irq") when bitmap_parselist() > was generalized to support userspace as well as kernelspace. > > Signed-off-by: Chris Metcalf > Cc: stable@vger.kernel.org I don't think we need to backport a fix for a 4 year old bug which has very minor consequences. Am I wrong? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/