Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754104AbbDTUS3 (ORCPT ); Mon, 20 Apr 2015 16:18:29 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:5384 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646AbbDTUSZ (ORCPT ); Mon, 20 Apr 2015 16:18:25 -0400 X-IronPort-AV: E=Sophos;i="5.11,610,1422950400"; d="scan'208";a="62461189" Message-ID: <55355F5B.6060504@broadcom.com> Date: Mon, 20 Apr 2015 13:19:39 -0700 From: Arun Ramamurthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , Tony Prisk , Alan Stern , "Greg Kroah-Hartman" , Arnd Bergmann , Felipe Balbi , Mathias Nyman , Paul Bolle , Thomas Pugliese , Srinivas Kandagatla , David Mosberger , Peter Griffin , "Gregory CLEMENT" , Laurent Pinchart , Kevin Hao CC: , , , Dmitry Torokhov , "Anatol Pomazau" , Jonathan Richardson , Scott Branden , Ray Jui , Subject: Re: [PATCHv2 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core References: <1428963047-23666-1-git-send-email-arun.ramamurthy@broadcom.com> <1428963047-23666-2-git-send-email-arun.ramamurthy@broadcom.com> <552E3699.4020309@ti.com> In-Reply-To: <552E3699.4020309@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3471 Lines: 99 On 15-04-15 02:59 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 14 April 2015 03:40 AM, Arun Ramamurthy wrote: >> Some generic drivers, such as ehci, may use multiple phys and for such >> drivers referencing phy(s) by name(s) does not make sense. Instead of >> inventing new naming schemes and using custom code to iterate through >> them, >> such drivers are better of using nameless phy bindings and using this >> newly >> introduced API to iterate through them. >> >> Signed-off-by: Arun Ramamurthy >> Reviewed-by: Ray Jui >> Reviewed-by: Scott Branden >> --- >> drivers/phy/phy-core.c | 32 ++++++++++++++++++++++++++++++++ >> include/linux/phy/phy.h | 2 ++ >> 2 files changed, 34 insertions(+) >> >> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c >> index 3791838..964a84d 100644 >> --- a/drivers/phy/phy-core.c >> +++ b/drivers/phy/phy-core.c >> @@ -623,6 +623,38 @@ struct phy *devm_of_phy_get(struct device *dev, >> struct device_node *np, >> EXPORT_SYMBOL_GPL(devm_of_phy_get); >> >> /** >> + * devm_of_phy_get_by_index() - lookup and obtain a reference to a >> phy by index. >> + * @dev: device that requests this phy >> + * @np: node containing the phy >> + * @index: index of the phy >> + * >> + * Gets the phy using _of_phy_get(), and associates a device with it >> using >> + * devres. On driver detach, release function is invoked on the >> devres data, >> + * then, devres data is freed. >> + * >> + */ >> +struct phy *devm_of_phy_get_by_index(struct device *dev, struct >> device_node *np, >> + int index) >> +{ >> + struct phy **ptr, *phy; >> + >> + ptr = devres_alloc(devm_phy_release, sizeof(*ptr), GFP_KERNEL); >> + if (!ptr) >> + return ERR_PTR(-ENOMEM); >> + >> + phy = _of_phy_get(np, index); >> + if (!IS_ERR(phy)) { >> + *ptr = phy; >> + devres_add(dev, ptr); >> + } else { >> + devres_free(ptr); >> + } >> + >> + return phy; >> +} >> +EXPORT_SYMBOL_GPL(devm_of_phy_get_by_index); >> + >> +/** >> * phy_create() - create a new phy >> * @dev: device that is creating the new phy >> * @node: device node of the phy >> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >> index a0197fa..ae2ffaf 100644 >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/phy.h >> @@ -133,6 +133,8 @@ struct phy *devm_phy_get(struct device *dev, const >> char *string); >> struct phy *devm_phy_optional_get(struct device *dev, const char >> *string); >> struct phy *devm_of_phy_get(struct device *dev, struct device_node *np, >> const char *con_id); >> +struct phy *devm_of_phy_get_by_index(struct device *dev, struct >> device_node *np, >> + int index); > > Add stubs for this function too. Also update the Documentation/phy.txt. > Kishon, I have added stubs for this function in my next patch set. However I am still unclear on whether I need to make GENERIC_PHY an invisible option or change my "select" to "depend" ? It seems like there was no consensus on this? Do you have any final thoughts before i send out the next patch set? Thanks > Thanks > Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/