MIME-Version: 1.0
In-Reply-To: <20150420203645.GE20701@google.com>
References: <1429546972-28400-1-git-send-email-ricardo.ribalda@gmail.com>
 <20150420192844.GD20701@google.com> <CAPybu_0oOtnHPAJfQM2iX5JrHy58LawNX-qhUHm8r83ZD1t+1Q@mail.gmail.com>
 <20150420203645.GE20701@google.com>
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Date: Mon, 20 Apr 2015 22:49:28 +0200
Message-ID: <CAPybu_0m5n5yvvp2ri3u=SyWLGMcPi1mDBgOEyk2AerUsSGoPQ@mail.gmail.com>
Subject: Re: [PATCH] kernel/resource: Invalid memory access in __release_resource
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Vivek Goyal <vgoyal@redhat.com>,
        Vinod Koul <vinod.koul@intel.com>, Cliff Wickman <cpw@sgi.com>,
        Jiang Liu <jiang.liu@linux.intel.com>,
        Jakub Sitnicki <jsitnicki@gmail.com>,
        Thierry Reding <treding@nvidia.com>, Mike Travis <travis@sgi.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Grant Likely <grant.likely@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 34

Hello

On Mon, Apr 20, 2015 at 10:36 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:

>> > From reading drivers/base/platform.c, it looks like the intent is
>> > that platform device users would use these interfaces:
>>
>> I can take a look to modify OF to use insert_resource(), but I still
>> think that no matter what, we should add this extra check, like the
>> propossed patch or maybe with a BUG_ON()....
>
> I think it would be nicer to make OF use platform_device_add_resources()
> and platform_device_add() because then there's less duplication of code.
> But Grant might have had a reason for avoiding that.
>
> Bjorn

I think I am going to make two patches, one  modifying OF as you
suggest, and another one
adding a BUG_ON to release_resource. Then you can decide to apply one
or two with the feedback from Grant

I have no hardware to test it right now, but tomorrow morning I can
test the patches and send them.


Thanks!
-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/