MIME-Version: 1.0
In-Reply-To: <465C1C8A-0819-4253-9525-6168CCCA133A@gatech.edu>
References: <1429500330.7977.29.camel@intel.com>
	<465C1C8A-0819-4253-9525-6168CCCA133A@gatech.edu>
Date: Mon, 20 Apr 2015 13:50:38 -0700
Message-ID: <CA+55aFy7_RXZ-B=3kqtpkRTT8e1i0D9TC-FHDx5v+w1ija1=Tw@mail.gmail.com>
Subject: Re: [LKP] [ocfs2] e2ac55b6a8e: ocfs2_init:1612 ERROR: Unable to
 create ocfs2 debugfs root
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Chengyu Song <csong84@gatech.edu>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: Huang Ying <ying.huang@intel.com>, LKML <linux-kernel@vger.kernel.org>,
        LKP ML <lkp@01.org>, Mark Fasheh <mfasheh@suse.com>,
        Joel Becker <jlbec@evilplan.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1143
Lines: 26

On Sun, Apr 19, 2015 at 8:45 PM, Chengyu Song <csong84@gatech.edu> wrote:
>
> As suggested in the patch,  -19 (-ENODEV) happens when debugfs is not configured (see include/linux/debugfs.h). So if debugfs is necessary for the functionality, in Kconfig, we should either declare it as a dependency, or auto select it.

That makes no sense.

If it used to work before that patch, then this is a regression and
the patch needs to be reverted.

Yes, the old code apparently used to set "o2hb_debug_dir" to an error
pointer when debugfs was compiled out, but since debugfs was compiled
out, that error pointer was probably never actually *used*. So things
presumably worked.

Now, it hangs, according to Huang Ying. If so, that's clearly a
regression. That means that commit e2ac55b6a8e3 ("ocfs2: incorrect
check for debugfs returns") needs to be reverted or fixed.

Andrew?

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/