Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754023AbbDTVJd (ORCPT ); Mon, 20 Apr 2015 17:09:33 -0400 Received: from www.linutronix.de ([62.245.132.108]:55833 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbbDTVJb (ORCPT ); Mon, 20 Apr 2015 17:09:31 -0400 Date: Mon, 20 Apr 2015 23:09:17 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: arnd@arndb.de, john.stultz@linaro.org, heenasirwani@gmail.com, pang.xunlei@linaro.org, peterz@infradead.org, rafael.j.wysocki@intel.com, gregkh@linuxfoundation.org, richardcochran@gmail.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, rth@twiddle.net, riel@redhat.com, cl@linux.com, tj@kernel.org, fweisbec@gmail.com, ahh@google.com, pjt@google.com, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH 09/11] cputime:Introduce the cputime_to_timespec64/timespec64_to_cputime function In-Reply-To: <1429509459-17068-10-git-send-email-baolin.wang@linaro.org> Message-ID: References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> <1429509459-17068-10-git-send-email-baolin.wang@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1596 Lines: 53 On Mon, 20 Apr 2015, Baolin Wang wrote: > This patch introduces some functions for converting cputime to timespec64 and back, > that repalce the timespec type with timespec64 type, as well as for arch/s390 and > arch/powerpc architecture. No. We want a patch which adds the functions and then a patch which uses them. This stuff is tricky and hard to review. So please split the patches into smaller chunks. > +unsigned long > +timespec64_to_jiffies(const struct timespec64 *value) > +{ > + return __timespec_to_jiffies(value->tv_sec, value->tv_nsec); > +} > +EXPORT_SYMBOL(timespec64_to_jiffies); So we have now two exports which are doing exactly the same thing. Copy and paste is wonderful, right? What about exporting __timespec_to_jiffies() and providing inlines for timespec_to_jiffies() and timespec64_to_jiffies() ? EXPORT_SYMBOL is not just a stupid annotation. Its impact on the resulting kernel size is larger than the actual function implementation. > +void > +jiffies_to_timespec64(const unsigned long jiffies, struct timespec64 *value) > +{ > + /* > + * Convert jiffies to nanoseconds and separate with > + * one divide. > + */ > + u32 rem; > + value->tv_sec = div_u64_rem((u64)jiffies * TICK_NSEC, > + NSEC_PER_SEC, &rem); > + value->tv_nsec = rem; > +} > +EXPORT_SYMBOL(jiffies_to_timespec64); Sigh. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/