Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240AbbDTVJn (ORCPT ); Mon, 20 Apr 2015 17:09:43 -0400 Received: from filtteri1.pp.htv.fi ([213.243.153.184]:45686 "EHLO filtteri1.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754031AbbDTVJl (ORCPT ); Mon, 20 Apr 2015 17:09:41 -0400 Date: Tue, 21 Apr 2015 00:09:33 +0300 From: Aaro Koskinen To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, Rusty Russell , Ralf Baechle , Florian Fainelli , linux-mips@linux-mips.org Subject: Re: mips build failures due to commit 8dd928915a73 (mips: fix up obsolete cpu function usage) Message-ID: <20150420210933.GB31618@fuloong-minipc.musicnaut.iki.fi> References: <20150420194028.GA10814@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420194028.GA10814@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1371 Lines: 33 Hi, On Mon, Apr 20, 2015 at 12:40:28PM -0700, Guenter Roeck wrote: > the upstream kernel fails to build mips:nlm_xlp_defconfig, > mips:nlm_xlp_defconfig, mips:cavium_octeon_defconfig, and possibly > other targets, with errors such as > > arch/mips/kernel/smp.c:211:2: error: > passing argument 2 of 'cpumask_set_cpu' discards 'volatile' qualifier > from pointer target type > arch/mips/kernel/process.c:52:2: error: > passing argument 2 of 'cpumask_test_cpu' discards 'volatile' qualifier > from pointer target type > arch/mips/cavium-octeon/smp.c:242:2: error: > passing argument 2 of 'cpumask_clear_cpu' discards 'volatile' qualifier > from pointer target type > > The problem was introduced with commit 8dd928915a73 (" mips: fix up > obsolete cpu function usage"). I would send a patch to fix it, but I > am not sure if removing 'volatile' from the variable declaration(s) > would be a good idea. I think removing volatile from cpu_callin_map declaration should be OK, since test_cpu (only reader) uses test_bit which takes care of it: static inline int test_bit(int nr, const volatile unsigned long *addr) A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/