Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbbDTXEy (ORCPT ); Mon, 20 Apr 2015 19:04:54 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:48078 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbbDTXEx (ORCPT ); Mon, 20 Apr 2015 19:04:53 -0400 Date: Tue, 21 Apr 2015 01:00:28 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, "David S. Miller" , Guenter Roeck , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN Message-ID: <20150420230028.GB32294@lunn.ch> References: <1429566206-14809-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429566206-14809-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 47 On Mon, Apr 20, 2015 at 05:43:26PM -0400, Vivien Didelot wrote: > Minor, use the explicit PORT_DEFAULT_VLAN define instead of 0x07. Hi Vivien I would not normally use the word "Minor" here, since it will end up in the commit log. Other than that: Acked-by: Andrew Lunn Thanks Andrew > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6xxx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c > index 48712bd..af639ab 100644 > --- a/drivers/net/dsa/mv88e6xxx.c > +++ b/drivers/net/dsa/mv88e6xxx.c > @@ -1274,7 +1274,8 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port) > /* Default VLAN ID and priority: don't set a default VLAN > * ID, and set the default packet priority to zero. > */ > - ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x07, 0x0000); > + ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_DEFAULT_VLAN, > + 0x0000); > abort: > mutex_unlock(&ps->smi_mutex); > return ret; > -- > 2.3.5 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/