Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbbDTXqf (ORCPT ); Mon, 20 Apr 2015 19:46:35 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36065 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914AbbDTXqd (ORCPT ); Mon, 20 Apr 2015 19:46:33 -0400 Date: Tue, 21 Apr 2015 01:46:29 +0200 From: Peter Zijlstra To: Hagen Paul Pfeifer Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: Re: [PATCH RFC] x86: enforce inlining for atomics Message-ID: <20150420234629.GB3182@worktop.meeting.verilan.com> References: <1429565231-4609-1-git-send-email-hagen@jauu.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429565231-4609-1-git-send-email-hagen@jauu.net> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 27 On Mon, Apr 20, 2015 at 11:27:11PM +0200, Hagen Paul Pfeifer wrote: > During some code analysis I realized that atomic_add, atomic_sub and > friends are not necessarily inlined AND that each function is defined > multiple times: > > atomic_inc: 544 duplicates > atomic_dec: 215 duplicates > atomic_dec_and_test: 107 duplicates > atomic64_inc: 38 duplicates > [...] > > Each definition is exact equally, e.g.: > > ffffffff813171b8 : > 55 push %rbp > 48 89 e5 mov %rsp,%rbp > f0 01 3e lock add %edi,(%rsi) > 5d pop %rbp > c3 retq > Urgh, that's a GCC fail, what version and compile flags? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/