Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959AbbDUCB6 (ORCPT ); Mon, 20 Apr 2015 22:01:58 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:48765 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbbDUCBy (ORCPT ); Mon, 20 Apr 2015 22:01:54 -0400 Date: Mon, 20 Apr 2015 22:01:53 -0400 (EDT) Message-Id: <20150420.220153.1027836111884807798.davem@davemloft.net> To: andrew@lunn.ch Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1 From: David Miller In-Reply-To: <20150420230507.GC32294@lunn.ch> References: <1429564763-10098-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20150420230507.GC32294@lunn.ch> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Apr 2015 19:01:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 22 From: Andrew Lunn Date: Tue, 21 Apr 2015 01:05:07 +0200 > On Mon, Apr 20, 2015 at 05:19:23PM -0400, Vivien Didelot wrote: >> mv88e6xxx_setup_port_common was writing to PORT_DEFAULT_VLAN (port >> offset 0x07) instead of PORT_CONTROL_1 (port offset 0x05). > > Hi Vivien > > Good catch. > >> Signed-off-by: Vivien Didelot > > Fixes: cca8b1337541 ("net: dsa: Use mnemonics rather than register numbers") > Acked-by: Andrew Lunn Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/