Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752326AbbDUC1M (ORCPT ); Mon, 20 Apr 2015 22:27:12 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:33603 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbbDUC1L (ORCPT ); Mon, 20 Apr 2015 22:27:11 -0400 MIME-Version: 1.0 In-Reply-To: References: <1429349091-11785-1-git-send-email-gavin.guo@canonical.com> Date: Tue, 21 Apr 2015 10:27:09 +0800 Message-ID: Subject: Re: [PATCH] mm/slab_common: Support the slub_debug boot option on specific object size From: Gavin Guo To: Christoph Lameter Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1220 Lines: 28 Hi Christoph, On Mon, Apr 20, 2015 at 11:40 PM, Christoph Lameter wrote: > On Sat, 18 Apr 2015, Gavin Guo wrote: > >> The slub_debug=PU,kmalloc-xx cannot work because in the >> create_kmalloc_caches() the s->name is created after the >> create_kmalloc_cache() is called. The name is NULL in the >> create_kmalloc_cache() so the kmem_cache_flags() would not set the >> slub_debug flags to the s->flags. The fix here set up a temporary >> kmalloc_names string array for the initialization purpose. After the >> kmalloc_caches are already it can be used to create s->name in the >> kasprintf. > > Ok if you do that then the dynamic creation of the kmalloc hostname can > also be removed. This patch should do that as well. Thanks for your reply. I put the kmalloc_names in the __initdata section. And it will be cleaned. Do you think the kmalloc_names should be put in the global data section to avoid the dynamic creation of the kmalloc hostname again? Gavin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/