Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbbDUCvx (ORCPT ); Mon, 20 Apr 2015 22:51:53 -0400 Received: from mail-vn0-f45.google.com ([209.85.216.45]:37654 "EHLO mail-vn0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbbDUCvv (ORCPT ); Mon, 20 Apr 2015 22:51:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <1429571743-27740-1-git-send-email-tyler.baker@linaro.org> Date: Mon, 20 Apr 2015 19:51:50 -0700 Message-ID: Subject: Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building From: Tyler Baker To: Andy Lutomirski Cc: Shuah Khan , Kevin Hilman , John Stultz , Darren Hart , David Herrmann , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2030 Lines: 59 On 20 April 2015 at 16:47, Andy Lutomirski wrote: > On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker wrote: >> On 20 April 2015 at 16:22, Andy Lutomirski wrote: >>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker wrote: >>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64. >>>> >>>> Cc: Andy Lutomirski >>>> Signed-off-by: Tyler Baker >>>> --- >>>> tools/testing/selftests/x86/Makefile | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >>>> index be93945..a5ca38b 100644 >>>> --- a/tools/testing/selftests/x86/Makefile >>>> +++ b/tools/testing/selftests/x86/Makefile >>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64) >>>> >>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall >>>> >>>> +all: >>>> + >>> >>> This... >>> >>>> UNAME_M := $(shell uname -m) >>>> >>>> +ifeq ($(CROSS_COMPILE),) >>>> # Always build 32-bit tests >>>> all: all_32 >>>> - >>>> # If we're on a 64-bit host, build 64-bit tests as well >>>> ifeq ($(UNAME_M),x86_64) >>>> all: all_64 >>>> endif >>>> +else >>>> +# No dependency on all when cross building >>>> +all: >>> >>> ...is redundant with this. If you delete the "else" and "all:" here, then: >> >> Ok, I will remove these bits from this patch. However, the else will >> need to be added back in the next patch of the series to override the >> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok >> with that. > > I'm fine with that, unless you or Shuah want to fix lib.mk. I will send a follow up series to address this issue. > > --Andy Tyler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/