Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752972AbbDUDL4 (ORCPT ); Mon, 20 Apr 2015 23:11:56 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:63621 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbbDUDLz (ORCPT ); Mon, 20 Apr 2015 23:11:55 -0400 Message-ID: <5535BEC8.20008@huawei.com> Date: Tue, 21 Apr 2015 11:06:48 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Namhyung Kim CC: , , , , , Subject: Re: [PATCH] perf: annotate: make it respect -i option. References: <1427954692-105642-1-git-send-email-wangnan0@huawei.com> <20150402081231.GC23913@sejong> In-Reply-To: <20150402081231.GC23913@sejong> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.69.129] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 38 On 2015/4/2 16:12, Namhyung Kim wrote: > On Thu, Apr 02, 2015 at 06:04:52AM +0000, Wang Nan wrote: >> There is a bug in perf annotate that it doesn't respect user provided >> '-i'/'--input' option: >> >> # perf record ls >> [ perf record: Woken up 1 times to write data ] >> [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ] >> # mv ./perf.data ./perf.data.new >> # perf annotate -i ./perf.data.new --stdio >> failed to open perf.data: No such file or directory (try 'perf record' first) >> >> This patch fix it by setting file path after option parsing, like >> what 'perf report' does. >> >> Signed-off-by: Wang Nan > > I guess other commands are also suffered from this bug.. anyway, > > Acked-by: Namhyung Kim > > Thanks, > Namhyung > Hi, Looks like the next patch 'perf kmem: Respect -i option' has already been collected by tip/master, but this patch is lost. Is there any problem? Thank you! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/