Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbbDUFdu (ORCPT ); Tue, 21 Apr 2015 01:33:50 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:53217 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbbDUFds (ORCPT ); Tue, 21 Apr 2015 01:33:48 -0400 Message-ID: <5535E109.3020001@ti.com> Date: Tue, 21 Apr 2015 11:02:57 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Arnd Bergmann , Arun Ramamurthy CC: Greg Kroah-Hartman , , Srinivas Kandagatla , Laurent Pinchart , , Thomas Pugliese , Peter Griffin , Jonathan Richardson , Anatol Pomazau , Ray Jui , Alan Stern , Dmitry Torokhov , David Mosberger , Gregory CLEMENT , Kevin Hao , Paul Bolle , Mathias Nyman , Scott Branden , , , Felipe Balbi , Tony Prisk Subject: Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index References: <1428963047-23666-1-git-send-email-arun.ramamurthy@broadcom.com> <552D2255.1050704@ti.com> <552D56EF.2020409@broadcom.com> <4138287.C3OjQp3FFm@wuerfel> In-Reply-To: <4138287.C3OjQp3FFm@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 32 Arnd, On Wednesday 15 April 2015 03:17 AM, Arnd Bergmann wrote: > On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote: >>> >>> [1] -> >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 >>> >> Kishon,removing select GENERIC_PHY also breaks the builds for certain >> architectures (i386 and x84_64). Is the consensus to leave the select >> but make GENERIC_PHY a invisible option? Thanks > > I think the best solution is > > - make GENERIC_PHY a silent option > - change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so > it will still work when all other phy drivers are disabled > - change the non-phy drivers that select GENERIC_PHY to either > use 'depends on' or no explicit dependency in case they are > still functional without the API. Note that > drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well, > not a consumer, despite being outside of drivers/phy. makes sense to me. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/