Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbbDUHLH (ORCPT ); Tue, 21 Apr 2015 03:11:07 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47031 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751864AbbDUHLE convert rfc822-to-8bit (ORCPT ); Tue, 21 Apr 2015 03:11:04 -0400 Date: Tue, 21 Apr 2015 09:11:00 +0200 From: Boris Brezillon To: =?UTF-8?B?R2HDq2w=?= PORTAY Cc: Nicolas Ferre , Alexandre Belloni , Jean-Christophe PLAGNIOL-VILLARD , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox Message-ID: <20150421091100.6bb8ba36@bbrezillon> In-Reply-To: <1429521218-9752-1-git-send-email-g.portay@overkiz.com> References: <1429521218-9752-1-git-send-email-g.portay@overkiz.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 41 Hi Gael, On Mon, 20 Apr 2015 11:13:38 +0200 Gaël PORTAY wrote: > Sort nodes, rename to match Atmel naming convention You should use -M when you generate your patches with format-patch: it keeps track of files that have been renamed instead of considering it as a removal + an addition. > and update the features > below: > - command-line, > - use proper serial uart, > - rename leds and gpio-keys, > - update to pwm-leds and > - fix gpio-key level. Please split this patch so we can easily review the changes. How about the following separation ? - rename dts file - use stdout-path - sanitize bootargs - led related changes (rename + pwm-leds) - gpio-key related changes (rename + fix level) Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/