Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbbDUHMO (ORCPT ); Tue, 21 Apr 2015 03:12:14 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:57182 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbbDUHMM (ORCPT ); Tue, 21 Apr 2015 03:12:12 -0400 Message-ID: <5535F83D.5000505@ti.com> Date: Tue, 21 Apr 2015 10:11:57 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mathias Nyman , , Maxime Ripard CC: , , , "Balbi, Felipe" , "ABRAHAM, KISHON VIJAY" Subject: Re: [PATCH 2/5] usb: xhci: plat: Create both HCDs before adding them References: <1427977409-7671-1-git-send-email-rogerq@ti.com> <1427977409-7671-3-git-send-email-rogerq@ti.com> <5534F296.8000104@linux.intel.com> <55361D42.8040101@ti.com> In-Reply-To: <55361D42.8040101@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1847 Lines: 50 fixed Kishon's id. On 21/04/15 12:49, Roger Quadros wrote: > On 20/04/15 15:35, Mathias Nyman wrote: >> Hi >> >> On 02.04.2015 15:23, Roger Quadros wrote: >>> As xhci_hcd is now allocated by usb_create_hcd(), we don't >>> need to add the primary HCD before creating the shared HCD. >>> >>> Creating the shared HCD before adding the primary HCD is particularly >>> useful for the OTG use case so that we know at the OTG core if >>> the HCD is in single configuration or dual (primary + shared) >>> configuration. >>> >> >> This doesn't apply as >> >> commit 7b8ef22ea547b80475ac7feab06fb15e0fc143d8 >> usb: xhci: plat: Add USB phy support >> >> changed xhci-plat.c since. >> >> I rebased it, and the changed version is sitting in the for-usb-next branch in: >> git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git >> >> But it appeared to me that usb_add_hcd() and usb_remove_hcd() will also >> call phy init and remove functions. As the order how hcds are created and added >> would change I'd need some more eyes on this to see if it will cause regression. >> >> Or maybe in the best case we could get rid of the "Add USB phy support" patch as >> we will call xhci_add_hcd() for the first hcd much later, and it could maybe init >> the phy for us? > > I thought usb_phy_*() stuff would be deprecated and we should use phy framework > instead i.e. phy_init() and friends. > > In fact usb_add_hcd() is already handling the phy for us. > So I'm in favor of getting rid of commit 7b8ef22ea547b80475ac7feab06fb15e0fc143d8 > (usb: xhci: plat: Add USB phy support) > > cheers, > -roger > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/