Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754638AbbDUI2b (ORCPT ); Tue, 21 Apr 2015 04:28:31 -0400 Received: from mga09.intel.com ([134.134.136.24]:47044 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754279AbbDUI20 (ORCPT ); Tue, 21 Apr 2015 04:28:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,614,1422950400"; d="scan'208";a="559297438" Date: Tue, 21 Apr 2015 16:10:21 +0800 From: Wanpeng Li To: Juri Lelli Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Juri Lelli Subject: Re: [PATCH 6/7] sched/deadline: depend on clearing throttled status in replenish_dl_entity Message-ID: <20150421081021.GA9030@kernel> Reply-To: Wanpeng Li References: <1428310399-13489-1-git-send-email-wanpeng.li@linux.intel.com> <1428310399-13489-6-git-send-email-wanpeng.li@linux.intel.com> <5536076F.9020404@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5536076F.9020404@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2006 Lines: 58 Hi Juri, On Tue, Apr 21, 2015 at 09:16:47AM +0100, Juri Lelli wrote: >Hi, > >On 06/04/2015 09:53, Wanpeng Li wrote: >> Since the natural place to clear ->dl_throttled is in replenish_dl_entity(), and >> the task which is adjusted the priority is the current, it will be dequeued and >> then enqueued w/ replenish which can guarantee ->dl_throttled can be cleared, >> this patch drop the clear throttled status in function rt_mutex_setprio. >> > >Patch looks good. But, I'd slightly change subject and changelog. Something like >this, maybe? > >sched/core: remove superfluous resetting of dl_throttled flag > >Resetting dl_throttled flag in rt_mutex_setprio (for a task that is going >to be boosted) is superfluous, as the natural place to do so is in >replenish_dl_entity(). If the task was on the runqueue and it is boosted >by a DL task, it will be enqueued back with ENQUEUE_REPLENISH flag set, >which can guarantee that dl_throttled is reset in replenish_dl_entity(). > >This patch drops the resetting of throttled status in function >rt_mutex_setprio(). Cool, many thanks for your review. :) Regards, Wanpeng Li > >Thanks, > >- Juri > >> Signed-off-by: Wanpeng Li >> --- >> kernel/sched/core.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 28b0d75..f1b9222 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -3037,7 +3037,6 @@ void rt_mutex_setprio(struct task_struct *p, int prio) >> if (!dl_prio(p->normal_prio) || >> (pi_task && dl_entity_preempt(&pi_task->dl, &p->dl))) { >> p->dl.dl_boosted = 1; >> - p->dl.dl_throttled = 0; >> enqueue_flag = ENQUEUE_REPLENISH; >> } else >> p->dl.dl_boosted = 0; >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/