Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbbDUIQy (ORCPT ); Tue, 21 Apr 2015 04:16:54 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:62202 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbbDUIQu convert rfc822-to-8bit (ORCPT ); Tue, 21 Apr 2015 04:16:50 -0400 Message-ID: <5536076F.9020404@arm.com> Date: Tue, 21 Apr 2015 09:16:47 +0100 From: Juri Lelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Wanpeng Li , Ingo Molnar , Peter Zijlstra CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 6/7] sched/deadline: depend on clearing throttled status in replenish_dl_entity References: <1428310399-13489-1-git-send-email-wanpeng.li@linux.intel.com> <1428310399-13489-6-git-send-email-wanpeng.li@linux.intel.com> In-Reply-To: <1428310399-13489-6-git-send-email-wanpeng.li@linux.intel.com> X-OriginalArrivalTime: 21 Apr 2015 08:16:47.0473 (UTC) FILETIME=[82CD6E10:01D07C0B] X-MC-Unique: A9vdj0ZuT46qOmV_mewSyQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1831 Lines: 51 Hi, On 06/04/2015 09:53, Wanpeng Li wrote: > Since the natural place to clear ->dl_throttled is in replenish_dl_entity(), and > the task which is adjusted the priority is the current, it will be dequeued and > then enqueued w/ replenish which can guarantee ->dl_throttled can be cleared, > this patch drop the clear throttled status in function rt_mutex_setprio. > Patch looks good. But, I'd slightly change subject and changelog. Something like this, maybe? sched/core: remove superfluous resetting of dl_throttled flag Resetting dl_throttled flag in rt_mutex_setprio (for a task that is going to be boosted) is superfluous, as the natural place to do so is in replenish_dl_entity(). If the task was on the runqueue and it is boosted by a DL task, it will be enqueued back with ENQUEUE_REPLENISH flag set, which can guarantee that dl_throttled is reset in replenish_dl_entity(). This patch drops the resetting of throttled status in function rt_mutex_setprio(). Thanks, - Juri > Signed-off-by: Wanpeng Li > --- > kernel/sched/core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 28b0d75..f1b9222 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -3037,7 +3037,6 @@ void rt_mutex_setprio(struct task_struct *p, int prio) > if (!dl_prio(p->normal_prio) || > (pi_task && dl_entity_preempt(&pi_task->dl, &p->dl))) { > p->dl.dl_boosted = 1; > - p->dl.dl_throttled = 0; > enqueue_flag = ENQUEUE_REPLENISH; > } else > p->dl.dl_boosted = 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/