Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753881AbbDUIcw (ORCPT ); Tue, 21 Apr 2015 04:32:52 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:37493 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbbDUIcp (ORCPT ); Tue, 21 Apr 2015 04:32:45 -0400 Date: Tue, 21 Apr 2015 17:32:43 +0900 Message-ID: <87a8y1vq38.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Tobias Klauser Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v8 01/17] h8300: Assembly headers. In-Reply-To: <20150420140034.GB9990@distanz.ch> References: <1429510413-14869-1-git-send-email-ysato@users.sourceforge.jp> <1429510413-14869-2-git-send-email-ysato@users.sourceforge.jp> <20150420140034.GB9990@distanz.ch> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2946 Lines: 92 At Mon, 20 Apr 2015 16:00:34 +0200, Tobias Klauser wrote: > > On 2015-04-20 at 08:13:17 +0200, Yoshinori Sato wrote: > [...] > > diff --git a/arch/h8300/include/asm/pgtable.h b/arch/h8300/include/asm/pgtable.h > > new file mode 100644 > > index 0000000..8341db6 > > --- /dev/null > > +++ b/arch/h8300/include/asm/pgtable.h > > @@ -0,0 +1,49 @@ > > +#ifndef _H8300_PGTABLE_H > > +#define _H8300_PGTABLE_H > > +#include > > +#include > > +#define pgtable_cache_init() do { } while (0) > > +extern void paging_init(void); > > +#define PAGE_NONE __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_SHARED __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_COPY __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_READONLY __pgprot(0) /* these mean nothing to NO_MM */ > > +#define PAGE_KERNEL __pgprot(0) /* these mean nothing to NO_MM */ > > +#define __swp_type(x) (0) > > +#define __swp_offset(x) (0) > > +#define __swp_entry(typ, off) ((swp_entry_t) { ((typ) | ((off) << 7)) }) > > +#define __pte_to_swp_entry(pte) ((swp_entry_t) { pte_val(pte) }) > > +#define __swp_entry_to_pte(x) ((pte_t) { (x).val }) > > +#define kern_addr_valid(addr) (1) > > +#define pgprot_writecombine(prot) (prot) > > +#define pgprot_noncached pgprot_writecombine > > + > > +static inline int pte_file(pte_t pte) { return 0; } > > No need to define pte_file() anymore, remap_file_pages(2) implementation > was replaced by emulation. OK. Remove it. > > +#define swapper_pg_dir ((pgd_t *) 0) > > +/* > > + * ZERO_PAGE is a global shared page that is always zero: used > > + * for zero-mapped memory areas etc.. > > + */ > > +#define ZERO_PAGE(vaddr) (virt_to_page(0)) > > + > > +/* > > + * These would be in other places but having them here reduces the diffs. > > + */ > > +extern unsigned int kobjsize(const void *objp); > > This prototypes doesn't need to be defined here, it's already in > linux/mm.h which is included where kobjsize is used. OK. > > +extern int is_in_rom(unsigned long); > > This function is no longer defined nor used in the rest of the tree, no > need for this prototype as well. > OK. Remove. > [...] > > diff --git a/arch/h8300/include/asm/sh_bios.h b/arch/h8300/include/asm/sh_bios.h > > new file mode 100644 > > index 0000000..9ce513c > > --- /dev/null > > +++ b/arch/h8300/include/asm/sh_bios.h > > @@ -0,0 +1,4 @@ > > +#ifndef SH_BIOS_H > > +#define SH_BIOS_H > > + > > +#endif > > Why this empty header? Can it be removed? It was necessary before, it's already unnecessary. Removed. Thanks. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/