Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbbDUJFV (ORCPT ); Tue, 21 Apr 2015 05:05:21 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:43454 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbbDUJFS (ORCPT ); Tue, 21 Apr 2015 05:05:18 -0400 Date: Tue, 21 Apr 2015 12:05:08 +0300 From: Dan Carpenter To: Vitaly Kuznetsov Cc: "K. Y. Srinivasan" , devel@linuxdriverproject.org, Haiyang Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths Message-ID: <20150421090508.GB14154@mwanda> References: <1429604274-12537-1-git-send-email-vkuznets@redhat.com> <1429604274-12537-2-git-send-email-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429604274-12537-2-git-send-email-vkuznets@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 23 On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote: > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c > index 54da66d..836386f 100644 > --- a/drivers/hv/channel.c > +++ b/drivers/hv/channel.c > @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, > list_del(&open_info->msglistentry); > spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); > > - if (err == 0) > - newchannel->state = CHANNEL_OPENED_STATE; > + if (err != 0) Doesn't the double negative not make it slightly more confusing? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/