Message-ID: <5536208E.4060105@overkiz.com>
Date: Tue, 21 Apr 2015 12:03:58 +0200
From: =?UTF-8?B?R2HDq2wgUE9SVEFZ?= <g.portay@overkiz.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Boris Brezillon <boris.brezillon@free-electrons.com>
CC: Nicolas Ferre <nicolas.ferre@atmel.com>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox
References: <1429521218-9752-1-git-send-email-g.portay@overkiz.com> <20150421091100.6bb8ba36@bbrezillon>
In-Reply-To: <20150421091100.6bb8ba36@bbrezillon>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1416
Lines: 46

On 21/04/2015 09:11, Boris Brezillon wrote:
> Hi Gael,
>
> On Mon, 20 Apr 2015 11:13:38 +0200
> Gaël PORTAY <g.portay@overkiz.com> wrote:
>
>> Sort nodes, rename to match Atmel naming convention
> You should use -M when you generate your patches with format-patch: it
> keeps track of files that have been renamed instead of considering it
> as a removal + an addition.

Ok, thanks, I did not know that option...

>> and update the features
>> below:
>>   - command-line,
>>   - use proper serial uart,
>>   - rename leds and gpio-keys,
>>   - update to pwm-leds and
>>   - fix gpio-key level.
> Please split this patch so we can easily review the changes.
> How about the following separation ?
>
> - rename dts file
> - use stdout-path
> - sanitize bootargs
> - led related changes (rename + pwm-leds)
> - gpio-key related changes (rename + fix level)

In fact, each changes were committed in single patch before I submitted 
them...

I just squashed them thinking it would be easier for you to check (only) 
for the "new" device-tree.... my bad :(

What about the node re-order? Do you prefer in dedicated commit or with 
the rename patch?

> Best Regards,
>
> Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/