Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754151AbbDUMSh (ORCPT ); Tue, 21 Apr 2015 08:18:37 -0400 Received: from smtp89.iad3a.emailsrvr.com ([173.203.187.89]:33496 "EHLO smtp89.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476AbbDUMSe (ORCPT ); Tue, 21 Apr 2015 08:18:34 -0400 X-Sender-Id: abbotti@mev.co.uk From: Ian Abbott To: Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten , Subject: [PATCH 0/2] staging: comedi: hide subdevice runflags stuff Date: Tue, 21 Apr 2015 13:18:09 +0100 Message-Id: <1429618691-7157-1-git-send-email-abbotti@mev.co.uk> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1229 Lines: 23 Keep the details of the comedi subdevice `runflags` member local to "comedi_fops.c". In particular, the usage of the `COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well with the others. It's used as a marker to indicate the subdevice's `private` pointer can be automatically freed by the subdevice clean-up code, whereas the others are associated with the operation of asynchronous comedi commands. Abstract it's usage away in a couple of new wrapper functions. 1) staging: comedi: wrap COMEDI_SRF_FREE_SPRIV usage 2) staging: comedi: move COMEDI_SRF_... macros to "comedi_fops.c" drivers/staging/comedi/comedi_fops.c | 41 ++++++++++++++++++++-- drivers/staging/comedi/comedi_internal.h | 1 + drivers/staging/comedi/comedidev.h | 18 +--------- drivers/staging/comedi/drivers.c | 2 +- .../staging/comedi/drivers/amplc_dio200_common.c | 6 ++-- 5 files changed, 45 insertions(+), 23 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/