Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982AbbDUNbx (ORCPT ); Tue, 21 Apr 2015 09:31:53 -0400 Received: from mail03v-smtp01.fnal.gov ([131.225.199.28]:14763 "EHLO ex-smtp.fnal.gov" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753423AbbDUNbw (ORCPT ); Tue, 21 Apr 2015 09:31:52 -0400 X-Greylist: delayed 324 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Apr 2015 09:31:52 EDT Message-ID: <55365002.4010707@fnal.gov> Date: Tue, 21 Apr 2015 08:26:26 -0500 From: Ron Rechenmacher Reply-To: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Christoph Hellwig CC: , Steven Rostedt Subject: Re: [PATCH] tracing: Export key trace event symbols References: <553571C3.1060505@fnal.gov> <20150421061034.GA9253@infradead.org> <55363CDC.4000305@fnal.gov> <20150421122202.GA8708@infradead.org> <55364CF4.2090600@fnal.gov> <20150421132355.GA18161@infradead.org> In-Reply-To: <20150421132355.GA18161@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [99.141.209.99] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1748 Lines: 49 But why export anything _GPL in the first place? Christoph Hellwig wrote on 04/21/15 08:23: > On Tue, Apr 21, 2015 at 08:13:24AM -0500, Ron Rechenmacher wrote: >> Hi Christoph, >> >> My module, and information about it, can be found at: >> https://cdcvs.fnal.gov/redmine/projects/trace >> https://cdcvs.fnal.gov/redmine/projects/trace/repository/show/src_module >> with the header at >> https://cdcvs.fnal.gov/redmine/projects/trace/repository/raw/include/trace.h > > And now send a patch including a rationale on why we need it. I haven't > looked deep enough, but so far I can't see any real value add in it. > >> >> It seems that you are the person that I have to convince in order to get >> my patch accepted. Is this true? > > In the end you'll need to convince a maintainer to apply it. > >> Can you tell me how: >> ./kernel/trace/power-traces.c:17:EXPORT_TRACEPOINT_SYMBOL_GPL(power_start); > > I can't find a tracepoint with that name in the current tree. > >> ./kernel/trace/power-traces.c:19:EXPORT_TRACEPOINT_SYMBOL_GPL(cpu_idle); > > This one is used by the potentially modular intel_idle (now cpuids) > driver, so it's exported for a reason. > >> should be allowed (how it fits with your definition of the Linux kernel below) and >> my proposed EXPORTS not? >> I hope that you will not suggest removing the above 2 exports. > > It's perfectly fine to remove unused exports, and we do it regularly > -- Ron Rechenmacher Engineer Fermi National Accelerator Laboratory Batavia, IL 60510 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/