Message-ID: <553658A0.8060409@ladisch.de>
Date: Tue, 21 Apr 2015 16:03:12 +0200
From: Clemens Ladisch <clemens@ladisch.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Laurent Vivier <laurent@vivier.eu>,
        Stefan Richter <stefanr@s5r6.in-berlin.de>
CC: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firewire: add a parameter to force the speed of the
	devices.
References: <1429576576-1637-1-git-send-email-laurent@vivier.eu>
	<1429576576-1637-3-git-send-email-laurent@vivier.eu>
In-Reply-To: <1429576576-1637-3-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 24

Laurent Vivier wrote:
> I was trying to use my old iPod mini firewire (first generation) with
> a new firewire card I put in my PC (VIA Technologies, Inc. VT6306/7/8),
> but the iPod was not mounted and failed with the following error:
>     reading config rom failed: no ack
> It appears that the configuration rom cannot be read after the
> device max speed is set to something else than SCODE_100.
>
> According to the iPod configuration ROM, it should support SCODE_400.
>
> This patch adds a a parameter (force_speed) to the firewire-core module
> to be able to set the max speed to use with the firewire devices.

Why a module parameter?  Why not automatically apply this workaround to
this specific device?


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/