Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbbDUOQm (ORCPT ); Tue, 21 Apr 2015 10:16:42 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:58852 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752266AbbDUOQi (ORCPT ); Tue, 21 Apr 2015 10:16:38 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Tue, 21 Apr 2015 16:16:22 +0200 From: Stefan Richter To: Clemens Ladisch Cc: Laurent Vivier , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] firewire: add a parameter to force the speed of the devices. Message-ID: <20150421161622.69637059@kant> In-Reply-To: <553658A0.8060409@ladisch.de> References: <1429576576-1637-1-git-send-email-laurent@vivier.eu> <1429576576-1637-3-git-send-email-laurent@vivier.eu> <553658A0.8060409@ladisch.de> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 28 On Apr 21 Clemens Ladisch wrote: > Laurent Vivier wrote: > > I was trying to use my old iPod mini firewire (first generation) with > > a new firewire card I put in my PC (VIA Technologies, Inc. VT6306/7/8), > > but the iPod was not mounted and failed with the following error: > > reading config rom failed: no ack > > It appears that the configuration rom cannot be read after the > > device max speed is set to something else than SCODE_100. > > > > According to the iPod configuration ROM, it should support SCODE_400. > > > > This patch adds a a parameter (force_speed) to the firewire-core module > > to be able to set the max speed to use with the firewire devices. > > Why a module parameter? Why not automatically apply this workaround to > this specific device? I doubt that this iPod model needs the workaround. I suspect the particular hardware combination needs one. -- Stefan Richter -=====-===== -=-- =-=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/