Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755517AbbDUP2f (ORCPT ); Tue, 21 Apr 2015 11:28:35 -0400 Received: from exprod5og101.obsmtp.com ([64.18.0.141]:58766 "EHLO exprod5og101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbbDUP2c (ORCPT ); Tue, 21 Apr 2015 11:28:32 -0400 MIME-Version: 1.0 Reply-To: semen.protsenko@globallogic.com In-Reply-To: References: <1429621752-19082-1-git-send-email-semen.protsenko@globallogic.com> Date: Tue, 21 Apr 2015 18:28:30 +0300 Message-ID: Subject: Re: [PATCH] genirq: check irq_ack callback in handle_edge_irq() before calling From: Sam Protsenko To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Grygorii Strashko , Linus Walleij Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 18 On Tue, Apr 21, 2015 at 5:40 PM, Thomas Gleixner wrote: > No, it's not missing by chance. It's missing on purpose. The edge > handler is designed to deal with edge type interrupt chips and those > have an ACK by definition. > > You are fixing the wrong place. That GPIO expander is using the wrong > flow handler. It should not use the edge handler at all. Just missed comments for handle_edge_irq() function, explaining why irq_ack is mandatory. So I just need to use handle_level_irq() in expander driver (instead of handle_edge_irq()). Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/