Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933048AbbDUP5v (ORCPT ); Tue, 21 Apr 2015 11:57:51 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:36613 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932695AbbDUP5m (ORCPT ); Tue, 21 Apr 2015 11:57:42 -0400 Message-ID: <1429631859.15866.28.camel@linaro.org> Subject: Re: [PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap" From: "Ivan T. Ivanov" To: Alan Stern Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vivek Gautam Date: Tue, 21 Apr 2015 18:57:39 +0300 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 23 On Tue, 2015-04-21 at 11:04 -0400, Alan Stern wrote: > On Tue, 21 Apr 2015, Ivan T. Ivanov wrote: > > > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use > > devm_ioremap_resource instead of devm_ioremap"), because msm_otg > > and this driver are using same address space to access AHB mode > > and USB command registers. > > Um, this patch is in fact _not_ a reversion of 70843f623b58. That > commit removed 4 lines of code and added 3. If this were truly a > reversion, it would remove 3 lines and add 4. Instead it adds 10. > > Please make this a true reversion. Right, but I will have to revert 2 commits then, is this ok? Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/