Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933139AbbDUQ45 (ORCPT ); Tue, 21 Apr 2015 12:56:57 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:36639 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932145AbbDUQ4y (ORCPT ); Tue, 21 Apr 2015 12:56:54 -0400 Date: Tue, 21 Apr 2015 12:56:53 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Ivan T. Ivanov" cc: Greg Kroah-Hartman , , , , Vivek Gautam Subject: Re: [PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap" In-Reply-To: <1429631859.15866.28.camel@linaro.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 29 On Tue, 21 Apr 2015, Ivan T. Ivanov wrote: > > On Tue, 2015-04-21 at 11:04 -0400, Alan Stern wrote: > > On Tue, 21 Apr 2015, Ivan T. Ivanov wrote: > > > > > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use > > > devm_ioremap_resource instead of devm_ioremap"), because msm_otg > > > and this driver are using same address space to access AHB mode > > > and USB command registers. > > > > Um, this patch is in fact _not_ a reversion of 70843f623b58. That > > commit removed 4 lines of code and added 3. If this were truly a > > reversion, it would remove 3 lines and add 4. Instead it adds 10. > > > > Please make this a true reversion. > > Right, but I will have to revert 2 commits then, is this ok? Yes, that's okay. I hadn't noticed that e507bf577e5a touched the same code. Just mention them both in the patch description. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/