Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756010AbbDURMO (ORCPT ); Tue, 21 Apr 2015 13:12:14 -0400 Received: from p3plex2out01.prod.phx3.secureserver.net ([184.168.131.12]:36612 "EHLO p3plex2out01.prod.phx3.secureserver.netIMP" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753058AbbDURML convert rfc822-to-8bit (ORCPT ); Tue, 21 Apr 2015 13:12:11 -0400 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/2] staging: comedi: hide subdevice runflags stuff Thread-Topic: [PATCH 0/2] staging: comedi: hide subdevice runflags stuff Thread-Index: AQHQfC1JiYMvGuEMUk+zTHpceDYAu51Xs/8A Date: Tue, 21 Apr 2015 17:12:10 +0000 Message-ID: References: <1429618691-7157-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1429618691-7157-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 27 On Tuesday, April 21, 2015 5:18 AM, Ian Abbott wrote: > Keep the details of the comedi subdevice `runflags` member local to > "comedi_fops.c". In particular, the usage of the > `COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well > with the others. It's used as a marker to indicate the subdevice's > `private` pointer can be automatically freed by the subdevice > clean-up code, whereas the others are associated with the operation of > asynchronous comedi commands. Abstract it's usage away in a couple of > new wrapper functions. > > 1) staging: comedi: wrap COMEDI_SRF_FREE_SPRIV usage > 2) staging: comedi: move COMEDI_SRF_... macros to "comedi_fops.c" > > drivers/staging/comedi/comedi_fops.c | 41 ++++++++++++++++++++-- > drivers/staging/comedi/comedi_internal.h | 1 + > drivers/staging/comedi/comedidev.h | 18 +--------- > drivers/staging/comedi/drivers.c | 2 +- > .../staging/comedi/drivers/amplc_dio200_common.c | 6 ++-- > 5 files changed, 45 insertions(+), 23 deletions(-) Reviewed-by: H Hartley Sweeten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/